Assignment in Expression

Background

An assigment in an expression might indicate a typing error. The programmer probably meant to compare a variable with a value. Causes for the assignment are:

Bad coding style: please extract the assignment from the expression.
Useless assignment: an assignment where the result is directly used as a parameter is useless when the result isn't further used.
Accidental assignment: probably meant to be a comparison.

The accidental assignment is already checked by Eclipse, unless a boolean is assigned.

Since 0.8.0

Example

Bad code:

Good code:

new ArrayList(amount = 20);

amount = 20;
new ArrayList(amount);

if (name = "MyClass")

if (name == "MyClass")

@SuppressWarnings

Warnings generated by this codecheck can be suppressed by adding the @SuppressWarnings("assignment") annotation.

Available quick fixes

The quick fixes for this code check extract the assignment from the expression.

Since 0.8.2

Bad code:		Good code:

new ArrayList(amount = 20);		amount = 20; new ArrayList(amount);

if (name = "MyClass")		if (name == "MyClass")